Re: regression tests fail for different block sizes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: regression tests fail for different block sizes
Date: 2014-05-14 06:11:04
Message-ID: 7981.1400047864@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> In master, 4 tests fail due to plan changes with blocksize 32K. The
> failures started creeping in around 9.0.

AFAIR, that's been true since the dark ages, not since 9.0.

> I don't see a clean way to make the plans consistent with 8K and 32K
> pages, so I was about to write this off as "we don't care much".

Indeed. There are any number of parameters that you can change that will
break the regression tests by changing plan choices. If we tried to
cover all such cases we'd end up with lobotomized tests that detect
fewer issues, not more.

> Then I ran with block size 1KB, and I got what appears to be a genuine
> failure related to range types and/or spgist.

This might be worth investigating, but it doesn't mean that we need
automated regression tests covering the case.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2014-05-14 06:32:26 Re: wrapping in extended mode doesn't work well with default pager
Previous Message Jeff Davis 2014-05-14 06:05:13 regression tests fail for different block sizes