Re: pgsql: Add deduplication to nbtree.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add deduplication to nbtree.
Date: 2020-03-02 17:47:46
Message-ID: 7971.1583171266@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Another issue I just noticed is that src/tools/pginclude/cpluspluscheck
complains thusly:

./src/include/access/nbtree.h: In function 'void BTreeTupleSetPosting(IndexTupleData*, int, int)':
./src/include/access/nbtree.h:384: warning: comparison between signed and unsigned integer expressions

I suppose this can be silenced with an appropriate cast, and doing so
would seem like a good idea.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2020-03-02 18:29:54 pgsql: Silence nbtree.h cpluspluscheck warning.
Previous Message Peter Geoghegan 2020-03-02 16:08:11 Re: pgsql: Add deduplication to nbtree.