| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com> |
| Cc: | "Masahiko Sawada" <sawada(dot)mshk(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Peter Smith" <smithpb2250(at)gmail(dot)com>, "Fabrice Chapuis" <fabrice636861(at)gmail(dot)com>, "Simon Riggs" <simon(dot)riggs(at)enterprisedb(dot)com>, "Petr Jelinek" <petr(dot)jelinek(at)enterprisedb(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Ajin Cherian" <itsajin(at)gmail(dot)com> |
| Subject: | Re: Logical replication timeout problem |
| Date: | 2022-05-09 13:30:52 |
| Message-ID: | 78d4b56b-f6a5-4260-90a6-9943e0e88ce6@www.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 9, 2022, at 3:47 AM, Amit Kapila wrote:
> Thanks. The patch LGTM. I'll push and back-patch this after the
> current minor release is done unless there are more comments related
> to this work.
Looks sane to me. (I only tested the HEAD version)
+ bool end_xact = ctx->end_xact;
Do you really need a new variable here? It has the same name and the new one
isn't changed during the execution.
Does this issue deserve a test? A small wal_receiver_timeout. Although, I'm not
sure how stable the test will be.
--
Euler Taveira
EDB https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2022-05-09 13:43:34 | Re: 2022-05-12 release announcement draft |
| Previous Message | Robert Haas | 2022-05-09 13:23:47 | Re: Mark all GUC variable as PGDLLIMPORT |