Re: pgsql: Add all structured objects passed to pushJsonbValue piecewise.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add all structured objects passed to pushJsonbValue piecewise.
Date: 2015-05-27 02:00:01
Message-ID: 7885.1432692001@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On 5/26/15 11:24 AM, Andrew Dunstan wrote:
>> Add all structured objects passed to pushJsonbValue piecewise.

> This causes a compiler warning:

> jsonb_util.c: In function 'pushJsonbValue':
> jsonb_util.c:535:3: error: passing argument 1 of 'JsonbIteratorInit'
> from incompatible pointer type [-Werror]

I'm getting multiple warnings (probably Peter's build is aborting
after the first one). Please fix.

jsonb_util.c: In function 'pushJsonbValue':
jsonb_util.c:535: warning: passing argument 1 of 'JsonbIteratorInit' from incompatible pointer type
../../../../src/include/utils/jsonb.h:422: note: expected 'struct JsonbContainer *' but argument is of type 'struct JsonbValue *'
jsonfuncs.c: In function 'addJsonbToParseState':
jsonfuncs.c:3257: warning: passing argument 3 of 'pushJsonbValue' from incompatible pointer type
../../../../src/include/utils/jsonb.h:420: note: expected 'struct JsonbValue *' but argument is of type 'struct JsonbContainer *'
jsonfuncs.c:3259: warning: passing argument 3 of 'pushJsonbValue' from incompatible pointer type
../../../../src/include/utils/jsonb.h:420: note: expected 'struct JsonbValue *' but argument is of type 'struct JsonbContainer *'
jsonfuncs.c:3237: warning: unused variable 'type'

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-05-27 02:15:28 pgsql: Remove configure check prohibiting threaded libpython on OpenBSD
Previous Message Robert Haas 2015-05-27 01:45:36 Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension