Re: buildfarm's typedefs list has gone completely nutso

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: buildfarm's typedefs list has gone completely nutso
Date: 2019-07-11 16:50:48
Message-ID: 7869.1562863848@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 7/10/19 8:24 PM, Andres Freund wrote:
>> I think that's kinda what I'm complaining about... It seems like a bad
>> idea to have this in the buildfarm code, rather than our code. IMO the
>> buildfarm code should invoke an updated src/tools/find_typedef - that
>> way people at least can create typedefs manually locally.

> OK, I don't have a problem with that. I think the sane way to go would
> be to replace it with what the buildfarm is using, more or less.

+1 for the idea --- I've not studied the code, but surely the buildfarm's
version of this code is more bulletproof.

> This looks like a bug in the version of objdump unless I'm reading it
> wrong. Why would this be tagged as a typedef?

Maybe. We still need to explain the other non-typedef symbols that have
just appeared and are not being reported by calliphoridae.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jesper Pedersen 2019-07-11 16:53:54 Re: Index Skip Scan
Previous Message Julien Rouhaud 2019-07-11 16:22:25 Re: Add parallelism and glibc dependent only options to reindexdb