| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: expressive test macros (was: Report test_atomic_ops() failures consistently, via macros) |
| Date: | 2019-10-07 20:07:30 |
| Message-ID: | 7840.1570478850@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 2019-10-07 19:57, Tom Lane wrote:
>> I'd just put them all in c.h. I see no reason why a new header
>> is helpful.
> Assert stuff is already in there, but surely stuff that calls elog()
> doesn't belong in there?
True, though I had the impression that Andres wanted to propose things
that would work in either frontend or backend, presumably with different
implementations. You could argue it either way as to whether to have
that in c.h (with an #ifdef) or separately in postgres.h and
postgres_fe.h.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-10-07 20:10:04 | Re: expressive test macros (was: Report test_atomic_ops() failures consistently, via macros) |
| Previous Message | Andres Freund | 2019-10-07 20:06:41 | Re: expressive test macros (was: Report test_atomic_ops() failures consistently, via macros) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-10-07 20:10:04 | Re: expressive test macros (was: Report test_atomic_ops() failures consistently, via macros) |
| Previous Message | Andres Freund | 2019-10-07 20:06:41 | Re: expressive test macros (was: Report test_atomic_ops() failures consistently, via macros) |