Re: Remove unused rel parameter in lookup_var_attr_stats

From: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>
To: fabriziomello(at)gmail(dot)com
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove unused rel parameter in lookup_var_attr_stats
Date: 2025-01-06 11:26:39
Message-ID: 783edd5c-f7e0-4068-92af-d46d6b410c9a@tantorlabs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 03.01.2025 18:42, Fabrízio de Royes Mello wrote:
>
> On Fri, Jan 3, 2025 at 11:09 AM Ilia Evdokimov
> <ilya(dot)evdokimov(at)tantorlabs(dot)com> wrote:
>
> Hi hackers,
>
> I've attached a small patch that remove unused parameter 'rel' from
> the static function lookup_var_attr_stats() in extended_stats.c
>
> While exploring src/backend/statistics, I noticed that there are
> several
> other parameters which appear to be unused. However, since the
> discussion around import/export statistics [1] attribute_stats.c is
> still ongoing and many functions from other files are non-static,
> those
> parameters may yet prove useful. Therefore, I'm only removing the
> parameter from this static function.
>
>
> LGTM looks like a leftover from a4d75c86.
>
> Regards,
>
> --
> Fabrízio de Royes Mello

True. Moreover, I checked the commit and found nothing else.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2025-01-06 12:21:09 Re: Re: proposal: schema variables
Previous Message Zhijie Hou (Fujitsu) 2025-01-06 11:22:08 RE: Conflict detection for update_deleted in logical replication