Re: text_pattern_ops and complex regexps

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: text_pattern_ops and complex regexps
Date: 2009-05-06 16:18:42
Message-ID: 7809.1241626722@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> I think changeable regex flavors turned out to be a bad idea. They can
> wreak all sorts of havoc. You change the setting, SIGHUP, and suddenly
> your application fails to work as expected. Maybe we should make that
> setting PGC_POSTMASTER (or just get rid of it?), and provide was to pass
> flags to change the flavor for particular operations (this is easy for
> function-based stuff but not so easy for operators). That way it
> doesn't intrude in stuff like cached plans and so on.

Maybe so. I think it was originally intended mostly as a
backwards-compatibility measure when we added the support for ARE
flavor. It's pretty likely that no one changes the flavor setting
in practice anymore. If we just locked it down as "advanced always"
then we could simplify the documentation by a measurable amount ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2009-05-06 16:26:22 Re: BUG #4796: Recovery followed by backup creates unrecoverable WAL-file
Previous Message Alvaro Herrera 2009-05-06 16:10:49 Re: text_pattern_ops and complex regexps