| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | kuroda(dot)hayato(at)fujitsu(dot)com, houzj(dot)fnst(at)fujitsu(dot)com, ikedamsh(at)oss(dot)nttdata(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Subject: | Re: Allow escape in application_name |
| Date: | 2021-12-24 08:01:55 |
| Message-ID: | 77ec3888-dffb-e3bb-f676-27ba4df1a8fb@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/12/24 13:49, Kyotaro Horiguchi wrote:
>> I'm ok to remove the check "values[i] != NULL", but think that it's
>> better to keep the other check "*(values[i]) != '\0'" as it
>> is. Because *(values[i]) can be null character and it's a waste of
>> cycles to call process_pgfdw_appname() in that case.
>
> Right. I removed too much.
Thanks for the check! So I kept the check "*(values[i]) != '\0'" as it is
and pushed the patch. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-12-24 08:04:51 | Re: sequences vs. synchronous replication |
| Previous Message | Tomas Vondra | 2021-12-24 07:23:13 | Re: sequences vs. synchronous replication |