From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | iphatiey5eu2au6(at)pasms(dot)be, pgsql-docs(at)lists(dot)postgresql(dot)org |
Subject: | Re: temporary file size clarification |
Date: | 2022-11-24 09:14:20 |
Message-ID: | 77B1C264-8B26-484A-9FE2-8DE82C71EAE4@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
> On 23 Nov 2022, at 20:43, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> On Wed, Nov 16, 2022 at 10:26:38AM +0000, PG Doc comments form wrote:
>> The following documentation comment has been logged on the website:
>>
>> Page: https://www.postgresql.org/docs/14/runtime-config-logging.html
>> Description:
>>
>> The setting log_temp_files will enable logging of the usage of temporary
>> files, including their size in the log files. The setting is given in
>> kilobytes, which is clearly documented. However, I could not find any clear
>> documentation that describes the unit of size that is used in the logfiles
>> themselves, the log line is something like "profiles(at)profiles LOG:
>> temporary file: path "base/pgsql_tmp/pgsql_tmp31863.1", size 3137536" but
>> there is no size unit in the logfile or in the settings documentation. Can
>> you add whether the log line is in bytes/kilobytes/megabytes?
>
> Uh, I believe it is simply in bytes.
It is, the relevant code path for the logging is:
if ((size / 1024) >= log_temp_files)
ereport(LOG,
(errmsg("temporary file: path \"%s\", size %lu",
path, (unsigned long) size)));
I don't think it's a bad idea to specify the unit in the documentation though,
as suggested by the OP. Since the setting considers a value without unit as
kb, and the logged value is without unit, there is room for confusion.
How about something like the attached?
--
Daniel Gustafsson https://vmware.com/
Attachment | Content-Type | Size |
---|---|---|
log_temp_files.diff | application/octet-stream | 705 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Laurenz Albe | 2022-11-24 10:33:55 | Re: nextval parameter is not clear |
Previous Message | Kirk Wolak | 2022-11-24 07:41:49 | Re: nextval parameter is not clear |