| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: backup manifests |
| Date: | 2020-04-09 14:06:56 |
| Message-ID: | 777d236e-f46c-8099-bb5e-a6e4efc43999@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/04/09 2:35, Robert Haas wrote:
> On Wed, Apr 8, 2020 at 1:15 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>> When there is a backup_manifest in the database cluster, it's included in
>> the backup even when --no-manifest is specified. ISTM that this is problematic
>> because the backup_manifest is obviously not valid for the backup.
>> So, isn't it better to always exclude the *existing* backup_manifest in the
>> cluster from the backup, like backup_label/tablespace_map? Patch attached.
>>
>> Also I found the typo in the document. Patch attached.
>
> Both patches look good. The second one is definitely a mistake on my
> part, and the first one seems like a totally reasonable change.
> Thanks!
Thanks for reviewing them! I pushed them.
Please note that the commit messages have not been delivered to
pgsql-committers yet.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2020-04-09 14:08:36 | Re: Report error position in partition bound check |
| Previous Message | Ashutosh Bapat | 2020-04-09 14:06:28 | Re: A problem about partitionwise join |