From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Cost of AtEOXact_Buffers in --enable-cassert |
Date: | 2010-08-06 18:23:15 |
Message-ID: | 7770.1281118995@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> The most prohibitively expensive part is the AtEOXact_Buffers check of running
> through all buffers and checking their pin count. And it makes $app's
> regression tests take thrice their time...
> Would somebody object agains putting those in an extra define so that those can
> be disabled in pg_config_manual? Or even disable it by default entirely...
Not a chance for the latter; this is an important sanity check that
catches real coding mistakes with some frequency.
I'd be willing to consider a "half assert" mode that turns off some of
the most expensive checks, but AtEOXact_Buffers is hardly the only thing
that ought to be in that list. The CLOBBER_FREED_MEMORY and memory
context checking stuff is pretty durn expensive too.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-08-06 18:30:24 | Re: including backend ID in relpath of temp rels - updated patch |
Previous Message | Tom Lane | 2010-08-06 18:16:32 | Re: including backend ID in relpath of temp rels - updated patch |