From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ash M <makmarath(at)hotmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
Subject: | Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name |
Date: | 2019-02-17 22:31:43 |
Message-ID: | 7757.1550442703@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> On Tue, 12 Feb 2019 at 16:09, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> FWIW, it makes me a bit uneasy to change this function signature in
>> back-branches if that's the intention as I suspect that it gets used
>> in extensions.. For HEAD that's fine of course.
> I wondered about this too and questioned Tom about it above. There
> was no response.
Sorry, I didn't realize you'd asked a question.
> I just assumed Tom didn't think it was worth fiddling with in back-branches.
Yeah, exactly. Not only do I not feel a need to change this behavior
in the back branches, but the original patch is *also* an API change,
in that it changes the behavior of what appears to be a well-defined
boolean parameter. The fact that none of the call sites found in
core today would care doesn't change that; you'd still be risking
breaking extensions, and/or future back-patches.
So I think targeting this for HEAD only is fine.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2019-02-17 23:38:20 | Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name |
Previous Message | David Rowley | 2019-02-17 22:17:52 | Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name |
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2019-02-17 22:36:37 | Re: REL_11_STABLE: dsm.c - cannot unpin a segment that is not pinned |
Previous Message | Andrew Gierth | 2019-02-17 22:22:03 | Re: Ryu floating point output patch |