From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Error code missing for "wrong length of inner sequence" error |
Date: | 2020-10-02 15:34:26 |
Message-ID: | 774e7f84-996b-0fa2-3783-109d71f040cc@iki.fi |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 02/10/2020 15:06, Daniel Gustafsson wrote:
>> On 2 Oct 2020, at 13:44, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>>
>> On 01/10/2020 14:21, Daniel Gustafsson wrote:
>>> On that note, wouldn't the dimension check errors in PLySequence_ToArray be
>>> just as well off using normal ereport()'s? Only one of them seem to error out
>>> in a way that could propagate an error from Python to postgres.
>>
>> Yes, you are right. I was going to say that we are not very
>> consistent on when to use ereport() and when PLy_elog() in general,
>> but looking closer, we are. Outside the array-conversion functions,
>> PLy_elog() is only used when a Python C API call fails, and
>> ereport() is used otherwise.
>
> I did another scan as well and couldn't find any other offenders.
Pushed. Thanks for checking!
- Heikki
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-10-02 16:07:58 | Re: Rejecting redundant options in Create Collation |
Previous Message | James Coleman | 2020-10-02 14:55:14 | Re: enable_incremental_sort changes query behavior |