| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Condor <condor(at)stz-bg(dot)com>, "pgsql-generallists(dot)postgresql(dot)org" <pgsql-general(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Unable to compile postgres 13.1 on Slackware current x64 |
| Date: | 2020-11-16 17:30:03 |
| Message-ID: | 772035.1605547803@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> It looks like something happened to ICU's boolean macros . See this
> commit in FreeBSD ports:
> https://github.com/freebsd/freebsd-ports/commit/81a88b4506ec06d07be10d199170ef4003eb0e30
It'd be so nice if people would tell us about their problems, instead of
just hacking-and-slashing.
In this case, I see one use of the constant TRUE in collationcmds.c,
but I wonder how come that's there given that we deprecated upper-case
TRUE some time ago. I find it hard to believe that sprinkling "#include
<stdbool.h>" into random places is either necessary (on modern platforms
anyway) or a good idea (if we're not using <stdbool.h>, this seems pretty
much guaranteed to break things); so I think the rest of that patch is
foolhardy.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Atul Kumar | 2020-11-16 17:38:39 | autovacuum recommendations for Large tables |
| Previous Message | Laurenz Albe | 2020-11-16 17:14:06 | Re: Unable to compile postgres 13.1 on Slackware current x64 |