Re: [v15 beta] pg_upgrade failed if earlier executed with -c switch

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: [v15 beta] pg_upgrade failed if earlier executed with -c switch
Date: 2022-06-03 16:55:28
Message-ID: 76AAF0D8-6C2F-4DAB-95C7-12E97A05723D@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 3 Jun 2022, at 18:26, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> Or we could revisit Tom's proposal in the thread that implemented the feature:
>> to have timestamped directory names to get around this very problem? I think
>> we should be able to figure out a way to make it easy enough for the BF code to
>> figure out (and clean up).
>
> How about inserting an additional level of subdirectory?
>
> pg_upgrade_output.d/20220603122528/foo.log
>
> Then code doing "rm -rf pg_upgrade_output.d" needs no changes.

Off the cuff that seems like a good compromise. Adding Andrew on CC: for input
on how that affects the buildfarm.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-06-03 16:56:20 Re: Proposal: adding a better description in psql command about large objects
Previous Message Tom Lane 2022-06-03 16:26:55 Re: [v15 beta] pg_upgrade failed if earlier executed with -c switch