Re: control max length of parameter values logged

From: Alexey Bashtanov <bashtanov(at)imap(dot)cc>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: control max length of parameter values logged
Date: 2020-04-01 09:10:55
Message-ID: 7699e55c-e603-9956-39fd-9f218fba4c72@imap.cc
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
>> + If greater than zero, bind parameter values reported in non-error
>> + statement-logging messages are trimmed to no more than this many bytes.
> Can I suggest to say:
>
> "Limit bind parameter values reported by non-error statement-logging messages
> to this many bytes". Or,
>
> "The maximum length of bind parameter values to log with non-error
> statement-logging messages".
Okay I'll rephrase.
> Could you make zero a normal value and -1 the "special" value to disable
> trimming ?
>
> Setting to zero will avoid displaying parameters at all, setting to -1 wil
> display values in full.
I can, but then for the sake of consistency I'll have to do the same for
log_parameter_max_length.
Then we'll end up with two ways to enable/disable parameter logging on
error:
using the primary boolean setting and setting length to 0.
One of them will require superuser privileges, the other one won't.
Do you think it's okay? I have no objections but I'm a bit worried
someone may find it clumsy.

Best, Alex

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-04-01 09:19:21 Re: Planning counters in pg_stat_statements (using pgss_store)
Previous Message movead.li@highgo.ca 2020-04-01 08:58:01 Re: recovery_target_action=pause with confusing hint