From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Michael Glaesemann <grzm(at)myrealbox(dot)com>, pgsql-patches(at)postgreSQL(dot)org, pgsql-interfaces(at)postgreSQL(dot)org |
Subject: | Re: Proposed p.tch for error locations |
Date: | 2006-03-13 15:57:07 |
Message-ID: | 7693.1142265427@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-interfaces pgsql-patches |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> This doesn't work on terminal using a variable-width font, does it?
> Sure, you can have all the interfaces use a monospace font, but it seems
> a weird thing to do. I think the line/character position should be
> returned in a separate error attribute in ereport. So for example
> pgAdmin could count characters and mark it in bold or use a different
> color.
That information is already available to pgAdmin, and has been since
7.4; if they are failing to exploit it that's their problem not libpq's.
Basically what's at stake here is the behavior of "dumb" applications
that are just using PQerrorMessage and not doing anything smart with
error message fields. It does not seem unreasonable to me to assume
fixed-width font in that context. We haven't seen any complaints about
psql doing it have we?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2006-03-13 16:03:35 | Re: Proposed p.tch for error locations |
Previous Message | Volkan YAZICI | 2006-03-13 15:55:31 | Re: Receiving SIGPIPE for PQfinish(<broken-connection>) |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2006-03-13 16:03:35 | Re: Proposed p.tch for error locations |
Previous Message | Tom Lane | 2006-03-13 15:44:24 | Re: Proposed patch for error locations |