From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: lo_create(oid, bytea) breaks every extant release of libpq |
Date: | 2014-06-12 05:08:08 |
Message-ID: | 7666.1402549688@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Noah Misch <noah(at)leadboat(dot)com> writes:
> On Wed, Jun 11, 2014 at 11:57:20PM -0400, Tom Lane wrote:
>> Meanwhile, we have to either revert the addition of lo_create(oid,
>> bytea) altogether, or choose a different name for it. Suggestions?
> lo_new() or lo_make()? An earlier draft of the patch that added
> lo_create(oid, bytea) had a similar function named make_lo().
I think we want to stick to the lo_xxx naming convention, whatever
xxx ends up being.
I was idly thinking that we might want to focus on the fact that this
function not only creates a LO but loads some data into it. lo_make
isn't too bad, but we could also consider lo_load, lo_import, etc.
(lo_import is not one of the names we have to avoid overloading.
OTOH, there's already a 2-argument form of it, so maybe there'd be
issues with resolving calls with unknown-literal arguments.)
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-06-12 05:18:22 | Re: Something flaky in the "relfilenode mapping" infrastructure |
Previous Message | Pavel Stehule | 2014-06-12 05:08:07 | Re: lo_create(oid, bytea) breaks every extant release of libpq |