| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | Murat Tuncer <mtuncer(at)gmail(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] BUG #14759: insert into foreign data partitions fail |
| Date: | 2017-08-01 03:45:26 |
| Message-ID: | 76479f01-6af9-7968-3845-9ca179e568a7@lab.ntt.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 2017/08/01 10:18, Amit Langote wrote:
> Good points; fixed in the updated patch.
I should have mentioned this in an earlier mail, but one thing I noticed
is this:
- the remote server.
+ the remote server. That becomes especially important if the table is
+ being used in a partition hierarchy, where it is recommended to add
+ a constraint matching the partition constraint expression on
+ the remote table.
I think this would apply to CHECK constraints on foreign tables when
implementing partitioning with inheritance. Why do we only mention this
for partition constraints?
Other than that, the patch looks good to me.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2017-08-01 04:21:39 | Re: BUG #14758: Segfault with logical replication on a function index |
| Previous Message | Amit Langote | 2017-08-01 01:18:27 | Re: BUG #14759: insert into foreign data partitions fail |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2017-08-01 04:17:55 | Re: Subscription code improvements |
| Previous Message | Amit Langote | 2017-08-01 03:10:30 | Re: A bug in mapping attributes in ATExecAttachPartition() |