| From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: [PATCH] Add pretty-printed XML output option |
| Date: | 2023-02-15 09:37:39 |
| Message-ID: | 75b74663-7fe8-c306-8914-1ada9a2bab41@uni-muenster.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 15.02.23 10:06, Peter Smith wrote:
> Bingo!! Your v9 patch now passes all 'make check' tests for me.
Nice! It also passed all tests in the patch tester.
> But I'll leave it to a committer to decide if this VERBOSITY toggle is
> the best fix.
I see now other test cases in the xml.sql file that also use this
option, so it might be a known "issue".
Shall we now set the patch to "Ready for Commiter"?
Thanks a lot for the review!
Best, Jim
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-02-15 09:51:26 | Re: Support logical replication of DDLs |
| Previous Message | Amit Kapila | 2023-02-15 09:16:49 | Re: Perform streaming logical transactions by background workers and parallel apply |