Re: [PATCH] Cleanup of GUC units code

From: Korry Douglas <korry(dot)douglas(at)enterprisedb(dot)com>
To: PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Andrew Sullivan <ajs(at)commandprompt(dot)com>
Subject: Re: [PATCH] Cleanup of GUC units code
Date: 2008-09-08 19:04:23
Message-ID: 752780DC-9ACA-4B93-9CCD-F53C90342377@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>> Settings in postgresql.conf are currently case-insensitive. Except
>> for the units.
>
> And, of course, filenames when you are using a case-sensitive
> filesystem. Because these are things that are defined by some
> convention other than the ones the PGDG made up. Since units fall
> into that category, it seems to me that we're stuck with using
> external conventions.

Just a thought... since there are very few (if any) places where a
user would specify a variable in terms of bits (kilobits, megabits,
gigabits), we could make the units case-insensitive and assume that
kb, gb, and mb (and all case variants) refer to some number of bytes.
If a user wants to specify a variable in terms of bits, he would have
to spell out the units completely, as in "4 gigabits", "20 kilobits",
or "16 megabits".

-- Korry

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2008-09-08 19:04:57 Re: Synchronous Log Shipping Replication
Previous Message Brendan Jurd 2008-09-08 18:40:39 Re: [Review] pgbench duration option