Re: Relcache leak when row triggers on partitions are fired by COPY

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Relcache leak when row triggers on partitions are fired by COPY
Date: 2017-05-16 01:17:51
Message-ID: 75267993-08c4-3e55-242d-2142e9622699@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017/05/16 10:03, Thomas Munro wrote:
> On Tue, May 16, 2017 at 12:32 PM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> I vote for ExecCleanupTriggerState(estate). After your patch, there will
>> be 4 places, including afterTriggerInvokeEvents(), ExecEndPlan(), and
>> EvalPlanQualEnd(), that repeat the same block of code.
>
> Ok, here's a patch like that.

Thanks, looks good to me.

> The call to ExecCloseIndices() may
> technically be redundant (we never opened them).

Actually yes. We never do ExecOpenIndices() on the ResultRelInfos
contained in es_trig_target_relations.

Thanks,
Amit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-05-16 01:23:00 Obsolete sentence in CREATE SUBSCRIPTION docs
Previous Message Masahiko Sawada 2017-05-16 01:05:45 Re: Server Crashes if try to provide slot_name='none' at the time of creating subscription.