| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Reset master xmin when hot_standby_feedback disabled. |
| Date: | 2014-07-15 18:15:09 |
| Message-ID: | 7513.1405448109@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> Reset master xmin when hot_standby_feedback disabled.
> If walsender has xmin of standby then ensure we
> reset the value to 0 when we change from hot_standby_feedback=on
> to hot_standby_feedback=off.
> Branch
> ------
> REL9_2_STABLE
While I'm not necessarily objecting to the content of this patch,
I do have a problem with the process. Where was the discussion of
why this change should be back-patched? (If I'm identifying it
correctly, this is a back-patch of commit bd56e7412, a year and a
half later. That should have been noted in the commit message, too,
rather than leaving people to reconstruct why you'd only committed
into two old branches.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2014-07-15 18:33:18 | pgsql: json_build_object and json_build_array are stable, not immutable |
| Previous Message | Alvaro Herrera | 2014-07-15 18:07:03 | pgsql: Add missing doc changes for ee80f043bc9b |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrízio de Royes Mello | 2014-07-15 19:19:05 | Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED |
| Previous Message | Christoph Berg | 2014-07-15 18:04:08 | Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED |