Re: Patch for bug #17056 fast default on non-plain table

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Patch for bug #17056 fast default on non-plain table
Date: 2021-06-17 21:24:55
Message-ID: 7509c21a-7eb1-68a8-55d2-8b9e4c7e7ac1@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 6/17/21 1:45 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> revised patch attached.
> OK. One other point is that in HEAD, you only need the hunk that
> prevents atthasmissing from becoming incorrectly set. The hacks
> to cope with it being already wrong are only needed in the back
> branches. Since we already forced initdb for beta2, there will
> not be any v14 installations in which pg_attribute contains
> a wrong value.
>
>

Good point. Should I replace the relcache.c changes in HEAD with an
Assert? Or just skip them altogether?

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-06-17 21:33:58 Re: Patch for bug #17056 fast default on non-plain table
Previous Message Tom Lane 2021-06-17 21:11:26 Re: Centralizing protective copying of utility statements