Re: New Object Access Type hooks

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Joshua Brindle <joshua(dot)brindle(at)crunchydata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Joe Conway <joe(at)crunchydata(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: New Object Access Type hooks
Date: 2022-03-22 16:09:20
Message-ID: 75066591-7437-13b9-aaa0-7d7a4789700c@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 3/22/22 12:02, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> That seems quite weird. I'm not sure how it's getting loaded at all if
>> not via shared_preload_libraries
> Some other animals are showing this:
>
> diff -U3 /home/postgres/pgsql/src/test/modules/test_oat_hooks/expected/test_oat_hooks.out /home/postgres/pgsql/src/test/modules/test_oat_hooks/results/test_oat_hooks.out
> --- /home/postgres/pgsql/src/test/modules/test_oat_hooks/expected/test_oat_hooks.out 2022-03-22 11:57:40.224991011 -0400
> +++ /home/postgres/pgsql/src/test/modules/test_oat_hooks/results/test_oat_hooks.out 2022-03-22 11:59:59.998983366 -0400
> @@ -48,6 +48,8 @@
> SELECT * FROM regress_test_table;
> NOTICE: in executor check perms: superuser attempting execute
> NOTICE: in executor check perms: superuser finished execute
> +NOTICE: in executor check perms: superuser attempting execute
> +NOTICE: in executor check perms: superuser finished execute
> t
> ---
> (0 rows)
> @@ -95,6 +97,8 @@
> ^
> NOTICE: in executor check perms: non-superuser attempting execute
> NOTICE: in executor check perms: non-superuser finished execute
> +NOTICE: in executor check perms: non-superuser attempting execute
> +NOTICE: in executor check perms: non-superuser finished execute
> t
> ---
> (0 rows)
> @@ -168,6 +172,8 @@
> ^
> NOTICE: in executor check perms: superuser attempting execute
> NOTICE: in executor check perms: superuser finished execute
> +NOTICE: in executor check perms: superuser attempting execute
> +NOTICE: in executor check perms: superuser finished execute
> t
> ---
> (0 rows)
>
>
> I can duplicate that by adding "force_parallel_mode = regress"
> to test_oat_hooks.conf, so a fair bet is that the duplication
> comes from executing the same hook in both leader and worker.
>
>

OK, thanks. My test didn't include that one setting :-(

If I can't com up with a very quick fix I'll revert it.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2022-03-22 16:11:09 Re: New Object Access Type hooks
Previous Message Tom Lane 2022-03-22 16:02:18 Re: New Object Access Type hooks