| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Andy Fan <zhihuifan1213(at)163(dot)com> |
| Subject: | Re: Parallel CREATE INDEX for GIN indexes |
| Date: | 2024-06-20 21:19:43 |
| Message-ID: | 74ef5493-c837-4861-afb0-7d07e3a35407@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here's a cleaned up patch series, merging the fixup patches into 0001.
I've also removed the memset() from ginInsertBAEntry(). This was meant
to fix valgrind reports, but I believe this was just a symptom of
incorrect handling of byref data types, which was fixed in 2024/05/02
patch version.
The other thing I did is cleanup of FIXME and XXX comments. There were a
couple stale/obsolete comments, discussing issues that have been already
fixed (like the scan wrapping around).
A couple things to fix remain, but all of them are minor. And there's
also a couple XXX comments, often describing thing that is then done in
one of the following patches.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| v20240620-0001-Allow-parallel-create-for-GIN-indexes.patch | text/x-patch | 56.7 KB |
| v20240620-0002-Use-mergesort-in-the-leader-process.patch | text/x-patch | 11.5 KB |
| v20240620-0003-Remove-the-explicit-pg_qsort-in-workers.patch | text/x-patch | 10.4 KB |
| v20240620-0004-Compress-TID-lists-before-writing-tuples-t.patch | text/x-patch | 8.0 KB |
| v20240620-0005-Collect-and-print-compression-stats.patch | text/x-patch | 5.1 KB |
| v20240620-0006-Enforce-memory-limit-when-combining-tuples.patch | text/x-patch | 14.7 KB |
| v20240620-0007-Detect-wrap-around-in-parallel-callback.patch | text/x-patch | 6.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2024-06-20 21:43:58 | Issue with "start another primitive scan" logic during nbtree array advancement |
| Previous Message | Andres Freund | 2024-06-20 20:58:49 | Re: Meson far from ready on Windows |