Re: pgsql: Fix assorted missing infrastructure for ON CONFLICT.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Peter Geoghegan <pg(at)heroku(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix assorted missing infrastructure for ON CONFLICT.
Date: 2016-05-11 21:09:00
Message-ID: 7490.1463000940@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Peter Geoghegan wrote:
>> What does this mean?
>>
>> + /* XXX broken */
>> if (attno < 0)
>> elog(ERROR, "system column in index");

> My guess is that it means we do support indexes in system columns (oid
> in particular) and that instead of an ugly error this should do
> something else. Maybe silently ignore the index.

I left that for a second patch, which is now pushed.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2016-05-12 12:33:41 pgsql: doc: Small wording change for clarity
Previous Message Tom Lane 2016-05-11 21:07:01 pgsql: Fix infer_arbiter_indexes() to not barf on system columns.