Re: tableam.h fails cpluspluscheck

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: tableam.h fails cpluspluscheck
Date: 2019-05-31 13:57:31
Message-ID: 74837.1559311051@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2019-05-30 14:01:00 -0400, Tom Lane wrote:
>> Kinda looks like you can't get away with using "struct" on a forward
>> declaration of something that is not actually a struct type.

> Ugh. Odd that only C++ compilers complain. I just removed the typedef,
> it's not needed anymore (it used to be neccessary before moving
> IndexBuildCallback's definition to tableam.h - but was wrong then too,
> just cpluspluscheck didn't notice).

Cool, thanks.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-05-31 14:45:26 Re: Time range
Previous Message Tom Lane 2019-05-31 13:56:45 Re: cpluspluscheck vs vpath