Re: [PATCHES] HP-UX PA-RISC/Itanium 64-bit Patch and HP-UX

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Shinji Teragaito <shinji(at)kobe(dot)hp(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] HP-UX PA-RISC/Itanium 64-bit Patch and HP-UX
Date: 2004-10-08 04:26:06
Message-ID: 7471.1097209566@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Shinji Teragaito <shinji(at)kobe(dot)hp(dot)com> writes:
152c152
< SHLIB_LINK += `$(CC) -print-libgcc-file-name`
---
> SHLIB_LINK += `$(CC) $(LDFLAGS) -print-libgcc-file-name`

Okay. I'm slightly worried about odd LDFLAGS values confusing this, but
we can deal with that when we see an example.

155c155
< LINK.shared = $(CC) $(LDFLAGS) -shared -Wl,-h -Wl,$(soname)
---
> LINK.shared = $(CC) $(LDFLAGS) -shared -Wl,-h -Wl,$(soname) -Wl,+b -Wl,$(libdir)

That looks good too. I think I had seen a truncated version of this
(just the +b part) and left it off because it didn't work.

I've applied both these changes.

58c58
< ifeq ($(with_gnu_ld), yes)
---
> ifeq ($(GCC), yes)

This I cannot apply; it breaks the gcc-with-HP-ld case, at least on my
personal installation (HPUX 10.20, gcc 2.95.3, HP ld). My tests on HP's
testdrive systems did not show any problem here --- what case are you
concerned about exactly?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-10-08 04:28:16 Re: Security implications of config-file-location patch
Previous Message Bruce Momjian 2004-10-08 04:21:06 Re: Security implications of config-file-location patch

Browse pgsql-patches by date

  From Date Subject
Next Message Oliver Jowett 2004-10-08 06:01:18 Re: Two-phase commit
Previous Message Shinji Teragaito 2004-10-08 03:26:04 Re: [PATCHES] HP-UX PA-RISC/Itanium 64-bit Patch and HP-UX