Re: coverage additions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: coverage additions
Date: 2019-05-30 21:54:23
Message-ID: 74512.1559253263@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Apparently, for ecpg you have to do "make checktcp" in order for some of
> the tests to run, and "make check-world" doesn't do that. Not sure
> what's a good fix for this; do we want to add "make -C
> src/interfaces/ecpg/test checktcp" to what "make check-world" does,
> or do we rather what to add checktcp as a dependency of "make check" in
> src/interfaces/ecpg?

> Or do we just not want this test to be run by default, and thus I should
> add "make -C src/interfaces/ecpg/test checktcp" to coverage.pg.org's
> shell script?

I believe it's intentionally not run by default because it opens up
an externally-accessible server port.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-05-30 21:54:36 Re: coverage additions
Previous Message Tom Lane 2019-05-30 21:46:28 Re: compiling PL/pgSQL plugin with C++