Re: RFC: adding pytest as a supported test framework

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: RFC: adding pytest as a supported test framework
Date: 2024-06-13 18:39:16
Message-ID: 7434E8E5-04D2-45FD-A1DE-DA50EE957D10@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 13 Jun 2024, at 20:09, Melanie Plageman <melanieplageman(at)gmail(dot)com> wrote:
>
> On Thu, Jun 13, 2024 at 7:27 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> On 13 Jun 2024, at 00:34, Melanie Plageman <melanieplageman(at)gmail(dot)com> wrote:
>>
>>> FWIW, I felt a lot of pain trying to write recovery TAP tests with
>>> IPC::Run's pumping functionality. It was especially painful (as
>>> someone who knows even less Perl than the "street fighting Perl"
>>> Thomas Munro has described having) before the additional test
>>> infrastructure was added in BackgroudPsql.pm last year.
>>
>> A key aspect of this, which isn't specific to Perl or our use of it, is that
>> this was done in backbranches which doesn't have the (recently) much improved
>> BackgroundPsql.pm. The quality of our tools and the ease of use they provide
>> is directly related to the investment we make into continuously improving our
>> testharness. Regardless of which toolset we adopt, if we don't make this
>> investment (taking learnings from the past years and toolsets into account)
>> we're bound to repeat this thread in a few years advocating for toolset X+1.
>
> True. And thank you for committing BackgroundPsql.pm (and Andres for
> starting that work). My specific case is likely one of a poor work
> person blaming her tools :)

I don't think it is since the tools we had then were really hard to use. I
wrote very similar tests to yours for the online checksums patch and they were
quite complicated to get right. The point is that the complexity was greatly
reduced by the community, and that kind of work will be equally important
regardless of toolset.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-06-13 18:39:56 Re: Conflict Detection and Resolution
Previous Message Robert Haas 2024-06-13 18:27:45 Re: Avoid orphaned objects dependencies, take 3