| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: WIP: new system catalog pg_wait_event |
| Date: | 2023-08-18 08:57:28 |
| Message-ID: | 7422edbb-bf81-4f4f-b260-ce4d39a31007@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 8/18/23 12:37 AM, Michael Paquier wrote:
> On Thu, Aug 17, 2023 at 04:37:22PM +0900, Masahiro Ikeda wrote:
>> On 2023-08-17 14:53, Drouvot, Bertrand wrote:
>> BTW, is it better to start with "Waiting" like any other lines?
>> For example, "Waiting for custom event \"worker_spi_main\" defined by an
>> extension".
>
> Using "Waiting for custom event" is a good term here.
Yeah, done in v8 just shared up-thread.
> I am wondering
> if this should be s/extension/module/, as an event could be set by a
> loaded library, which may not be set with CREATE EXTENSION.
>
I think that removing "extension" sounds weird given the fact that the
wait event type is "Extension" (that could lead to confusion).
I did use "defined by an extension module" in v8 (also that's aligned with
the wording used in wait_event.h).
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Junwang Zhao | 2023-08-18 09:10:10 | [dsm] comment typo |
| Previous Message | Drouvot, Bertrand | 2023-08-18 08:56:55 | Re: WIP: new system catalog pg_wait_event |