From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
Cc: | Rahila Syed <rahilasyed90(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Enhancing Memory Context Statistics Reporting |
Date: | 2025-04-08 21:27:41 |
Message-ID: | 74105887-E4EF-4CA2-9F0A-3C0CE05BF632@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 8 Apr 2025, at 18:41, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> I noticed that the third argument of pg_get_process_memory_contexts() is named
> "retries" in pg_proc.dat, while the documentation refers to it as "timeout".
I've committed this patch as it was obviously correct, thanks!
> Also, as I mentioned earlier, I encountered an issue when calling
> pg_get_process_memory_contexts() on the PID of a backend that had just
> encountered an error but hadn't finished rolling back. It led to
> the following situation:
I reconfirmed that the bugfix that Rahila shared in [0] fixes this issue (and
will fix others like it, as it's not related to this patch in particular but is
a bug in DSM attaching). My plan is to take that for a more thorough review
and test tomorrow and see how far it can be safely backpatched. Thanks for
bringing this up, sorry about it getting a bit lost among all the emails.
--
Daniel Gustafsson
[0] CAH2L28shr0j3JE5V3CXDFmDH-agTSnh2V8pR23X0UhRMbDQD9Q(at)mail(dot)gmail(dot)com
From | Date | Subject | |
---|---|---|---|
Next Message | Jacob Champion | 2025-04-08 21:32:09 | Re: [PoC] Federated Authn/z with OAUTHBEARER |
Previous Message | David Rowley | 2025-04-08 21:22:03 | Re: Remove unnecessary static type qualifiers |