On 08.10.23 07:15, Thomas Munro wrote:
>> About your patch:
>>
>> I think you should have a "check" function called from
>> check_new_cluster(). That check function can then also handle the "not
>> supported" case, and you don't need to handle that in
>> parseCommandLine(). I suggest following the clone example for these,
>> since the issues there are very similar.
>
> Done.
This version looks good to me.
Tiny nit: You copy-and-pasted "%s/PG_VERSION.clonetest"; maybe choose a
different suffix.