| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Daniel Verite <daniel(at)manitou-mail(dot)org> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: insensitive collations |
| Date: | 2019-03-08 10:07:55 |
| Message-ID: | 73bdccc6-4163-ed7d-59d6-f6f379cf5080@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-03-04 15:58, Daniel Verite wrote:
> For the LIKE operator, I think the fix should be that like_fixed_prefix()
> should always return Pattern_Prefix_None for non-deterministic collations.
Good catch. I added the fix to match_pattern_prefix() instead. That
would be the place to change if someone wanted to fix this properly in
the future. While testing this, I also found a somewhat related problem
with _pattern_ops operator classes, which also need to be prohibited
with nondeterministic collations.
Updated patch attached, also with some merge conflicts resolved.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Collations-with-nondeterministic-comparison.patch | text/plain | 161.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-03-08 10:09:44 | Re: insensitive collations |
| Previous Message | Amit Langote | 2019-03-08 09:18:00 | Re: speeding up planning with partitions |