| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "Shinoda, Noriyoshi (PN Japan A&PS Delivery)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |
| Date: | 2020-03-10 17:19:14 |
| Message-ID: | 73940482-c176-77ca-7593-8e657f4c88e1@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/03/10 22:43, Amit Langote wrote:
> On Tue, Mar 10, 2020 at 6:09 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>>> So, I will make the patch adding support for --no-estimate-size option
>>> in pg_basebackup.
>>
>> Patch attached.
>
> Like the idea and the patch looks mostly good.
Thanks for reviewing the patch!
> + total size. If the estimation is disabled in
> + <application>pg_basebackup</application>
> + (i.e., <literal>--no-estimate-size</literal> option is specified),
> + this is always <literal>0</literal>.
>
> "always" seems unnecessary.
Fixed.
> + This option prevents the server from estimating the total
> + amount of backup data that will be streamed. In other words,
> + <literal>backup_total</literal> column in the
> + <structname>pg_stat_progress_basebackup</structname>
> + view always indicates <literal>0</literal> if this option is enabled.
>
> Here too.
Fixed.
Attached is the updated version of the patch.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
| Attachment | Content-Type | Size |
|---|---|---|
| add_no_estimate_size_v2.patch | text/plain | 7.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2020-03-10 17:38:01 | Re: [PATCH] Connection time for \conninfo |
| Previous Message | Alexey Kondratov | 2020-03-10 17:05:24 | Re: Conflict handling for COPY FROM |