| From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix a typo in pgstatfuncs.c |
| Date: | 2022-08-10 08:46:03 |
| Message-ID: | 738d6dcd-1e7b-d61a-9832-4659bd5676e7@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 8/10/22 10:30 AM, Bharath Rupireddy wrote:
> On Wed, Aug 10, 2022 at 1:22 PM Drouvot, Bertrand <bdrouvot(at)amazon(dot)com> wrote:
>> Hi,
>>
>> It seems like there's the following typo in pgstatfuncs.c:
>>
>> - /* Values only available to role member or
>> pg_read_all_stats */
>> + /* Values only available to role member of
>> pg_read_all_stats */
>>
>> Attaching a tiny patch to fix it.
> I don't think it's a typo, the comment says that the values are only
> available to the user who has privileges of backend's role or
> pg_read_all_stats, the macro HAS_PGSTAT_PERMISSIONS says it all.
Looking at HAS_PGSTAT_PERMISSIONS, i think you are right: sorry for the
noise.
Thanks!
Bertrand Drouvot
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-08-10 08:55:57 | Small typo in OAT README |
| Previous Message | Thomas Munro | 2022-08-10 08:41:04 | Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work |