回复:Queries that should be canceled will get stuck on secure_write function

From: 蔡梦娟(玊于) <mengjuan(dot)cmj(at)alibaba-inc(dot)com>
To: "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Andres Freund" <andres(at)anarazel(dot)de>, "alvherre" <alvherre(at)alvh(dot)no-ip(dot)org>, "masao(dot)fujii" <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: "pgsql-hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: 回复:Queries that should be canceled will get stuck on secure_write function
Date: 2021-09-21 16:14:49
Message-ID: 737f86a2-a387-4e29-b4c3-1dc22ca3211d.mengjuan.cmj@alibaba-inc.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all, I want to know your opinion on this patch, or in what way do you think we should solve this problem?
------------------------------------------------------------------
发件人:蔡梦娟(玊于) <mengjuan(dot)cmj(at)alibaba-inc(dot)com>
发送时间:2021年9月9日(星期四) 17:38
收件人:Robert Haas <robertmhaas(at)gmail(dot)com>; Andres Freund <andres(at)anarazel(dot)de>; alvherre <alvherre(at)alvh(dot)no-ip(dot)org>; masao.fujii <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
抄 送:pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
主 题:回复:Queries that should be canceled will get stuck on secure_write function

I changed the implementation about this problem:
a) if the cancel query interrupt is from db for some reason, such as recovery conflict, then handle it immediately, and cancel request is treated as terminate request;
b) if the cancel query interrupt is from client, then ignore as original way

In the attached patch, I also add a tap test to generate a recovery conflict on a standby during the backend process is stuck on client write, check whether it can handle the cancel query request due to recovery conflict.

what do you think of it, hope to get your reply

Thanks & Best Regards

Attachment Content-Type Size
0001-Handle-cancel-interrupts-during-client-readwrite.patch application/octet-stream 8.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2021-09-21 16:20:52 Re: proposal: possibility to read dumped table's name from file
Previous Message Bossart, Nathan 2021-09-21 16:13:24 Re: Deduplicate code updating ControleFile's DBState.