| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows |
| Date: | 2017-11-20 00:49:01 |
| Message-ID: | 7371.1511138941@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-11-19 19:08:48 -0500, Simon Riggs wrote:
>> Am investigating the few buildfarm failures
> The tests look very sensitive to differences in tuple size due to
> different alignment requirements. Dependant on what MAXALIGN (and some
> others) is the number of tuples fitting on a page will differ.
"Few" buildfarm failures? It's probably going to fail on every 32-bit host.
TBH, I would just remove those test cases. Even if they were stable
across platforms, they don't directly prove anything at all about
whether the feature does what it's supposed to.
(Also, scaling the results to blocksize seems unlikely to help in
passing on different BLCKSZ configurations...)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-11-20 00:52:24 | Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows |
| Previous Message | Tom Lane | 2017-11-20 00:37:18 | Re: pgsql: Remove BufFile's isTemp flag. |