Re: Changing the state of data checksums in a running cluster

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: Tomas Vondra <tomas(at)vondra(dot)me>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Changing the state of data checksums in a running cluster
Date: 2024-10-08 20:39:57
Message-ID: 7348EF6D-B31A-416C-A39B-1C40E8743565@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 7 Oct 2024, at 20:42, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> wrote:
>
> Tomas Vondra <tomas(at)vondra(dot)me> writes:
>
>> 3) unnecessary ListCell in DataChecksumsWorkerMain() on line 1345,
>> shadowing earlier variable
>
> All the ListCell variables can be eliminated by using the foreach_ptr
> and foreach_oid macros instead of plain foreach.

Fair point, done in the v4 attached upthread.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2024-10-08 20:56:05 Re: BitmapHeapScan streaming read user and prelim refactoring
Previous Message Daniel Gustafsson 2024-10-08 20:38:36 Re: Changing the state of data checksums in a running cluster