Re: Some architectures need "signed char" declarations

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Doug McNaught <doug(at)wireboard(dot)com>
Cc: Oliver Elphick <olly(at)lfix(dot)co(dot)uk>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Some architectures need "signed char" declarations
Date: 2002-01-09 15:24:37
Message-ID: 7313.1010589877@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Doug McNaught <doug(at)wireboard(dot)com> writes:
> Hmmm, according to my knowledge of C, 'c' should be an int here, as
> EOF is guaranteed not to collide with any legal char value.

I agree with Doug: EOF is not supposed to be equal to any value of
'char', therefore changing the variables to signed char will merely
break something else. Probably the variables should be int; are their
values coming from getc() or some such? Will look at it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-01-09 15:28:24 Re: Time as keyword
Previous Message Tom Lane 2002-01-09 15:14:05 Re: again on index usage