Re: Fix some memory leaks in ecpg.addons

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Tristan Partin" <tristan(at)neon(dot)tech>
Cc: "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix some memory leaks in ecpg.addons
Date: 2023-11-08 17:07:45
Message-ID: 730401.1699463265@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Tristan Partin" <tristan(at)neon(dot)tech> writes:
> clang and gcc both now support -fsanitize=address,undefined. These are
> really useful to me personally when trying to debug issues.
> Unfortunately ecpg code has a ton of memory leaks, which makes builds
> really painful. It would be great to fix all of them, but I don't have
> the patience to try to read flex/bison code. Here are two memory leak
> fixes in any case.

I'm kind of failing to see the point. As you say, the ecpg
preprocessor leaks memory like there's no tomorrow. But given its
usage (process one source file and exit) I'm not sure that is worth
much effort to fix. And what does it buy to fix just two spots?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-11-08 17:11:31 Re: Syncrep and improving latency due to WAL throttling
Previous Message Tristan Partin 2023-11-08 17:01:06 Fix some memory leaks in ecpg.addons