Re: GiST operator class for bool

Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> writes:
> Pushed, after adding some simple EXPLAIN to the regression test.

skink is reporting that this has some valgrind issues [1].
I suspect sloppy conversion between bool and Datum, but
didn't go looking.

==1805451== VALGRINDERROR-BEGIN
==1805451== Uninitialised byte(s) found during client check request
==1805451== at 0x59EFEA: PageAddItemExtended (bufpage.c:346)
==1805451== by 0x2100B9: gistfillbuffer (gistutil.c:46)
==1805451== by 0x2050F9: gistplacetopage (gist.c:562)
==1805451== by 0x20546B: gistinserttuples (gist.c:1277)
==1805451== by 0x205BB5: gistinserttuple (gist.c:1230)
==1805451== by 0x206067: gistdoinsert (gist.c:885)
==1805451== by 0x2084FB: gistBuildCallback (gistbuild.c:829)
==1805451== by 0x23B572: heapam_index_build_range_scan (heapam_handler.c:1694)
==1805451== by 0x208E7D: table_index_build_scan (tableam.h:1756)
==1805451== by 0x208E7D: gistbuild (gistbuild.c:309)
==1805451== by 0x2D10C8: index_build (index.c:2983)
==1805451== by 0x2D2A7D: index_create (index.c:1232)
==1805451== by 0x383E67: DefineIndex (indexcmds.c:1128)
==1805451== Address 0x10cab1e4 is 12 bytes inside a block of size 16 client-defined
==1805451== at 0x712AC5: palloc0 (mcxt.c:1118)
==1805451== by 0x1E0A07: index_form_tuple (indextuple.c:146)
==1805451== by 0x210BA8: gistFormTuple (gistutil.c:582)
==1805451== by 0x2084C2: gistBuildCallback (gistbuild.c:813)
==1805451== by 0x23B572: heapam_index_build_range_scan (heapam_handler.c:1694)
==1805451== by 0x208E7D: table_index_build_scan (tableam.h:1756)
==1805451== by 0x208E7D: gistbuild (gistbuild.c:309)
==1805451== by 0x2D10C8: index_build (index.c:2983)
==1805451== by 0x2D2A7D: index_create (index.c:1232)
==1805451== by 0x383E67: DefineIndex (indexcmds.c:1128)
==1805451== by 0x5AED2E: ProcessUtilitySlow (utility.c:1535)
==1805451== by 0x5AE262: standard_ProcessUtility (utility.c:1066)
==1805451== by 0x5AE33A: ProcessUtility (utility.c:527)
==1805451==
==1805451== VALGRINDERROR-END

regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2021-11-06%2023%3A56%3A57