Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".
Date: 2017-08-07 19:21:34
Message-ID: 7295.1502133694@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 07/31/2017 01:02 PM, Tom Lane wrote:
>> Record full paths of programs sought by "configure".

> The problem with this commit, as jacana is demonstrating, is that on
> Msys it finds the wrong prove. configure needs to run against the perl
> we build against, i.e. a native Windows perl, but prove needs to run
> with the perl from the MSys DTK that understands MSys virtualized
> paths. I have a hack that will allow the buildfarm to overcome the
> difficulty, (essentially it passes 'PROVE=prove' to make) but that's
> fairly ugly and certainly non-intuitive for someone running an MSys
> build and TAP tests without the buildfarm client.

I'm confused. AFAIK, that commit did not change which "prove" would
be used --- at least not unless you change PATH between configure and
make. It only changed how specifically that program would be named in
Makefile.global. Please clarify how that broke anything.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2017-08-07 19:31:50 Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".
Previous Message Peter Eisentraut 2017-08-07 18:36:54 pgsql: Update SQL features list

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-08-07 19:29:03 Re: Crash report for some ICU-52 (debian8) COLLATE and work_mem values
Previous Message Robert Haas 2017-08-07 19:16:08 Re: expanding inheritance in partition bound order