Re: tuplesort_gettuple_common() and *should_free argument

Peter Geoghegan <pg(at)heroku(dot)com> writes:
> On Wed, Dec 7, 2016 at 11:55 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>> Should we be worried about breaking the API of tuplesort_get* functions?
>> They might be used by extensions. I think that's OK, but wanted to bring it
>> up. This would be only for master, of course, and any breakage would be
>> straightforward to fix.

> I don't think so. I'm not aware of any third party extensions that
> call tuplesort.c routines, despite having looked for them. I noticed
> that pg_repack doesn't. For any that do, they'll break in a
> predictable, obvious way.

Adding or subtracting function arguments is something we do all the time.
As long as it's not proposed for back-patch, I don't see a problem.

regards, tom lane