Re: Archive recovery crashes on win32 in HEAD - hot standby related?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Archive recovery crashes on win32 in HEAD - hot standby related?
Date: 2010-01-16 16:10:00
Message-ID: 7286.1263658200@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sat, Jan 16, 2010 at 8:19 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> Not knowing that code very well at this time, but is this perhaps a
>> structure not being properly initialized in EXEC_BACKEND case?

> It looks like KnownAssignedXidsHash is not initialized. That's
> supposed to happen when CreateSharedProcArray calls
> KnownAssignedXidsInit, but that only happens for the first process to
> call that function... but without EXEC_BACKEND it'll just work anyway.

That code is completely broken as far as the division of labor between
"first" and not "first" is concerned ...

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-01-16 16:22:57 Re: Hot Standby and handling max_standby_delay
Previous Message Tom Lane 2010-01-16 16:04:06 Re: [COMMITTERS] pgsql: Fix one more cast for _open_osfhandle().