Re: Bad bug in fopen() wrapper code

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Bad bug in fopen() wrapper code
Date: 2006-09-24 16:56:06
Message-ID: 7258.1159116966@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> Attached patch sets the O_CREAT option when appending to files.

That looks correct, but I went looking to see if there were any other
mistakes of the same ilk, and I'm wondering what the sense is in
openFlagsToCreateFileFlags ... seems like it's ignoring O_EXCL in
some combinations and not others. Is that right?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-09-24 17:00:22 Re: pg_ctl error msg on Windows 2000
Previous Message Magnus Hagander 2006-09-24 16:31:22 Re: pg_regress starting postmaster

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-09-24 17:00:22 Re: pg_ctl error msg on Windows 2000
Previous Message Magnus Hagander 2006-09-24 15:32:44 Updates to pg_regress.c