Re: GetOldestWALSendPointer() in header

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: GetOldestWALSendPointer() in header
Date: 2010-06-16 15:00:32
Message-ID: 7212.1276700432@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> GetOldestWALSendPointer() is commented out in the source code
> with NOT_USED block, but is still declared in the header file.
> Should we remove the function prototype from walsender.h ?

Yes, that's our usual convention.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Steve Singer 2010-06-16 15:20:22 9.0 beta2 pg_upgrade: malloc 0 bytes patch
Previous Message Andrew Dunstan 2010-06-16 14:51:44 Re: PL/Perl function naming