Re: Crash with empty dictionary

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Hamid Quddus Akhtar" <hamid(dot)akhtar(at)enterprisedb(dot)com>
Cc: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Crash with empty dictionary
Date: 2007-08-22 14:18:27
Message-ID: 7201.1187792307@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Hamid Quddus Akhtar" <hamid(dot)akhtar(at)enterprisedb(dot)com> writes:
>> Offhand I'd say that an empty file is a legitimate corner case,
>> so we should just take it silently.

> Shouldn't we be warning about an empty file rather than just swallowing
> up the error?

You are jumping to a conclusion, namely that it is an error. If it's
a legitimate corner case, throwing a warning every time the file is
read would be incredibly annoying.

If it's not a legitimate case, then we should throw a real error.
A warning just strikes me as the worst of both worlds.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-08-22 14:24:41 Re: Crash with empty dictionary
Previous Message Tom Lane 2007-08-22 13:52:07 Re: A couple of tsearch loose ends